mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 42355: Removed the timeout from the filter.
Date Fri, 22 Jan 2016 01:24:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42355/
-----------------------------------------------------------

(Updated Jan. 22, 2016, 1:24 a.m.)


Review request for mesos, Ben Mahler and Joris Van Remoortere.


Changes
-------

Ben's comments.


Bugs: MESOS-4302
    https://issues.apache.org/jira/browse/MESOS-4302


Repository: mesos


Description
-------

Without the timeout, we rely on filter expiration only. This guarantees
that filter removal is scheduled after `allocate()` if the allocator is
backlogged given default parameters are used. Additionally we ensure the
filter timeout is at least as big as the allocation interval.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp 53d8784a3c4f0467756d7bd924e624ba4585e776 

Diff: https://reviews.apache.org/r/42355/diff/


Testing (updated)
-------

`make check` on Mac OS 10.10.4


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message