mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 42274: Added common command utils file.
Date Fri, 22 Jan 2016 00:55:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42274/
-----------------------------------------------------------

(Updated Jan. 22, 2016, 12:55 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

added method for sha512 digest.


Repository: mesos


Description
-------

This common file is a good place to add common command line utilities like tar,
digests(sha256, sha512, etc). Currently this functionality is spread in the code
base and this change would enable all those call sites to be replaced with a
common code.


Diffs (updated)
-----

  src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
  src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
  src/common/command_utils.hpp PRE-CREATION 
  src/common/command_utils.cpp PRE-CREATION 
  src/tests/common/command_utils_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/42274/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message