mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume based on 'DiskInfo.Source'.
Date Thu, 21 Jan 2016 20:01:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42472/#review115681
-----------------------------------------------------------



src/slave/slave.cpp (lines 2260 - 2272)
<https://reviews.apache.org/r/42472/#comment176697>

    I'm still not sure if we should create sub-directories in MOUNT disk or not. The reason
is because we won't be able to create sub-directories in BLOCK/RAW disk, do we want to introduce
a different behavior here?
    
    I'd prefer to be consistent between BLOCK and MOUNT type.


- Jie Yu


On Jan. 21, 2016, 7:37 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42472/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 7:37 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-4400
>     https://issues.apache.org/jira/browse/MESOS-4400
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We now create persistent volume directories based on 'DiskInfo.Source'
> if it is present.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp bd7fe03f8a8b07c6201db2f876f4f9cd7dc337cf 
> 
> Diff: https://reviews.apache.org/r/42472/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message