mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 41932: Updated "teardown_framework" requests in the authorizer.
Date Thu, 21 Jan 2016 08:32:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41932/#review115593
-----------------------------------------------------------


Looks great. Create a separate test for shutdown vs. teardown ACLs, and then we can Ship It!


src/tests/teardown_tests.cpp (lines 150 - 157)
<https://reviews.apache.org/r/41932/#comment176589>

    In this case, you should be testing both ACLs separately, rather than one test for a single
ACLs message that includes the same policy in both message formats.
    So how about a TeardownEndpointGoodACLs and a TeardownEndpointGoodDeprecatedACLs?


- Adam B


On Jan. 13, 2016, 11:53 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41932/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 11:53 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4154
>     https://issues.apache.org/jira/browse/MESOS-4154
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated "teardown_framework" requests in the authorizer.
> 
> 
> Diffs
> -----
> 
>   src/authorizer/local/authorizer.cpp c1db9c2131ea8fbf835278203a240f108c6372c5 
>   src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae 
> 
> Diff: https://reviews.apache.org/r/41932/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message