mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case the net_cls cgroup subsystem is disabled.
Date Wed, 20 Jan 2016 09:00:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42211/#review115386
-----------------------------------------------------------


Bad patch!

Reviews applied: [42047]

Failed command: ./support/apply-review.sh -n -r 42047

Error:
 2016-01-20 09:00:52 URL:https://reviews.apache.org/r/42047/diff/raw/ [9082/9082] -> "42047.patch"
[1]
Total errors found: 0
Checking 2 files
Error: Commit message summary (the first line) must not exceed 72 characters.

- Mesos ReviewBot


On Jan. 20, 2016, 5:15 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42211/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 5:15 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4262
>     https://issues.apache.org/jira/browse/MESOS-4262
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added filters to disable NetClsIsolator tests in case the net_cls cgroup subsystem is
disabled.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.cpp a6322f260c23796ceaa5d2080126ea9fef0b5ac6 
> 
> Diff: https://reviews.apache.org/r/42211/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> * Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator
tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message