mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 41789: Expose the http::internal::request function.
Date Wed, 20 Jan 2016 08:09:25 GMT


> On Jan. 19, 2016, 7:11 p.m., Adam B wrote:
> > 3rdparty/libprocess/include/process/http.hpp, lines 812-814
> > <https://reviews.apache.org/r/41789/diff/11-17/?file=1189248#file1189248line812>
> >
> >     Seems like a good candidate for a doxygen-style @param
> 
> Yongqiao Wang wrote:
>     I think @param is for /* */ style. In // style i find some guys use '', you can find
another one in https://github.com/apache/mesos/blob/master/src/master/master.hpp#L560

We're slowly trying to move the entire code base to `/* */` doxygen style. The line you reference
is from May 2015, but you'll notice that newer functions in master.hpp and even in http.hpp
use the new doxygen style.
See http://mesos.apache.org/documentation/latest/doxygen-style-guide/
"This guide introduces a consistent style for documenting Mesos source code using Doxygen.
There is an ongoing, incremental effort with the goal to document all public Mesos, libprocess,
and stout APIs this way. For now, existing code may not follow these guidelines, but new code
should."


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/#review115326
-----------------------------------------------------------


On Jan. 17, 2016, 10:48 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41789/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2016, 10:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil Conway, and
Qian Zhang.
> 
> 
> Bugs: MESOS-3763
>     https://issues.apache.org/jira/browse/MESOS-3763
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose the internal::http::request function in the header and not add an additional method/overload
for put function.
> 
> (TODO): Clean the other instances of post/get to use the http::request method.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 1fe549e9c3c64b310048388d90ab04e5641e08a1

>   3rdparty/libprocess/src/http.cpp 40fd87c4aa1417d4746a5e4268c30c0e55d0ec0e 
>   3rdparty/libprocess/src/tests/http_tests.cpp c23d0bf1929686cfc42969f39ce046f4794539d4

> 
> Diff: https://reviews.apache.org/r/41789/diff/
> 
> 
> Testing
> -------
> 
> Make & Make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message