mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 42252: Enabled master totalResources include allocation slack.
Date Wed, 20 Jan 2016 06:52:34 GMT


> On 一月 20, 2016, 3:43 a.m., Klaus Ma wrote:
> > src/master/master.cpp, line 4659
> > <https://reviews.apache.org/r/42252/diff/1/?file=1195793#file1195793line4659>
> >
> >     It checked Optimistic Offer Phase 1 is enabled in https://reviews.apache.org/r/41847/.
But I think it's not necessary. Checking the flag at `addSlave`, `updateAllocation` and `updateAvailable`
in enough. In other place, we just need to handle the case that `allocationSlack` is empty;
this case is also true when flag is enable by no `statless.reserved` resources.

You can add your comments to https://reviews.apache.org/r/40632/


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42252/#review115339
-----------------------------------------------------------


On 一月 13, 2016, 2:37 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42252/
> -----------------------------------------------------------
> 
> (Updated 一月 13, 2016, 2:37 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph
Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4321
>     https://issues.apache.org/jira/browse/MESOS-4321
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After master call updateSlave, the totalResources do not include
> allocation resources, this will cause some problem when end user
> using /state endpoint to check resources status.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp c122c30d943813fc3ce9e7025783c7231809b022 
> 
> Diff: https://reviews.apache.org/r/42252/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message