mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 41597: Extending allocator interface to support dynamic weights.
Date Wed, 20 Jan 2016 05:43:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/#review115349
-----------------------------------------------------------

Ship it!


Looks great. Just a couple of nits after your recent changes.

By the way, the diff page is getting crowded with 51 different versions of the patch. You
don't need to upload rebases after every potentially conflicting commit.  Most of the time
it's a simple enough change that the committer could do a fuzzy patch apply to get it, or
we're far enough away from actually committing that we don't need it rebased as frequently.
But other than flooding my email inbox and crowding ReviewBoard, there aren't any negative
effects, so upload rebases as often as you deem necessary. It just seems like you upload them
more often than anybody else I've seen.


src/master/allocator/mesos/hierarchical.cpp (lines 1055 - 1056)
<https://reviews.apache.org/r/41597/#comment176328>

    Comment no longer applies, remove it.



src/master/allocator/mesos/hierarchical.cpp (line 1057)
<https://reviews.apache.org/r/41597/#comment176330>

    `CHECK(weightInfo.has_role());`


- Adam B


On Jan. 18, 2016, 12:53 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41597/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 12:53 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-3943
>     https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add the interface in allocator to support updating weight
> at runtime, and the allocator is invoked to allocate the
> resources based on the updated weights later.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp e163669c9c4e4c98572968f18987704b60722a79 
>   include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
>   include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd 
>   src/master/allocator/mesos/allocator.hpp 581eaad376e7b2febe0b6359014617b935a677a3 
>   src/master/allocator/mesos/hierarchical.hpp 101482156ffc5a4fe3cd60be222bfe609330ec3c

>   src/master/allocator/mesos/hierarchical.cpp 48acde69b1a2f305b568a7e322a58708063dd30a

>   src/master/allocator/sorter/drf/sorter.hpp 050896e8b12cd4097ccd137d5284d6b39b0f06ab

>   src/master/allocator/sorter/drf/sorter.cpp 3a442f121f3a1505513877a5c78458a4b8d0a824

>   src/master/allocator/sorter/sorter.hpp 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
>   src/tests/allocator.hpp 206e9ac3a83038a691f7929bdd627042b0f363b0 
> 
> Diff: https://reviews.apache.org/r/41597/diff/
> 
> 
> Testing
> -------
> 
> Make & Make check successfully!
> 
> Test case: https://reviews.apache.org/r/41672/
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message