mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.
Date Wed, 20 Jan 2016 03:41:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41963/
-----------------------------------------------------------

(Updated Jan. 19, 2016, 7:41 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Timothy Chen.


Changes
-------

Add a NOTE to point people to the reason why we don't fail upon failure to recover loggers.


Bugs: MESOS-4150
    https://issues.apache.org/jira/browse/MESOS-4150


Repository: mesos


Description
-------

Adds a call to `ContainerLogger::recover` inside each containerizer's `Containerizer::recover`.


Diffs (updated)
-----

  src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0 
  src/slave/containerizer/mesos/containerizer.cpp ba4daf5cc68c9200b27799aaf4772212d9b0aa80


Diff: https://reviews.apache.org/r/41963/diff/


Testing
-------

make check (OSX & Centos7)

sudo bin/mesos-tests.sh --gtest_filter="*ROOT*" (Centos7)


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message