mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41779: Extended Subprocess::FD to optionally not duplicate the given FD.
Date Wed, 20 Jan 2016 03:41:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41779/
-----------------------------------------------------------

(Updated Jan. 19, 2016, 7:41 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
-------

Renamed FD::CLOEXEC to FD::OWNED.


Summary (updated)
-----------------

Extended Subprocess::FD to optionally not duplicate the given FD.


Bugs: MESOS-4136
    https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description (updated)
-------

This new option is useful when a subprocess is started with a FD, and the parent process does
not need the FD afterwards.  In this case, the FD does not need to be duplicated before being
sent to the child process.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/subprocess.hpp 8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec

  3rdparty/libprocess/src/subprocess.cpp 863523404b9ef1d2024c108f3e9e1c77c3916049 

Diff: https://reviews.apache.org/r/41779/diff/


Testing
-------

Tests are run in the next review.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message