mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <klaus1982...@gmail.com>
Subject Re: Review Request 41858: Added helper functions to kill executor.
Date Wed, 20 Jan 2016 03:21:11 GMT


> On Jan. 8, 2016, 3:49 p.m., Jian Qiu wrote:
> > src/slave/slave.cpp, line 4886
> > <https://reviews.apache.org/r/41858/diff/2/?file=1187210#file1187210line4886>
> >
> >     Should this be used also by qos_correction?
> 
> Guangya Liu wrote:
>     Want to leverage but because of `log` issues, the `qosCorrections` has many special
logs related with QoS controller, it is difficult to make `qosCorrections` leverage this.
Do you have any idea/comments for how to improve?
> 
> Joseph Wu wrote:
>     I would recommend refactoring out the body of `if (correction.type() == QoSCorrection::KILL)
{`.
>     
>     Instead of logging directly, return an `Option<Error>`.  
>     The QoS controller can do `LOG(WARNING) << "Ignoring QoS correction KILL: "
<< error.get();`.

@Joseph, good suggestion. I'll move the common part into a function.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41858/#review113429
-----------------------------------------------------------


On Jan. 8, 2016, 3:02 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41858/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 3:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere,
Joseph Wu, and Jian Qiu.
> 
> 
> Bugs: MESOS-4265
>     https://issues.apache.org/jira/browse/MESOS-4265
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> kill executors helper
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
> 
> Diff: https://reviews.apache.org/r/41858/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message