mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilbert Song" <songzihao1...@gmail.com>
Subject Re: Review Request 41491: Exposed docker/appc image manifest to mesos containerizer.
Date Wed, 20 Jan 2016 02:56:50 GMT


> On Jan. 17, 2016, 10:57 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/provisioner/provisioner.hpp, line 60
> > <https://reviews.apache.org/r/41491/diff/10/?file=1198406#file1198406line60>
> >
> >     We only expose Docker image manifest? But the summary of this RR says we will
expose both docker and appc image manifest.

Thanks. Msg fixed.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/#review114958
-----------------------------------------------------------


On Jan. 15, 2016, 11:04 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41491/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 11:04 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4225
>     https://issues.apache.org/jira/browse/MESOS-4225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed docker/appc image manifest to mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 4202f5552174ad3ab595ab3f16ab91d0854951f0

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 023f7363f33c4a927fae11037a408f6747fc3c39

>   src/slave/containerizer/mesos/provisioner/store.hpp aec725f789f7aeb92abfcc6718c2e6e2f1f37981

>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664

> 
> Diff: https://reviews.apache.org/r/41491/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message