mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 41285: Made Executor struct assign `pid` to be None() explicitly.
Date Wed, 20 Jan 2016 01:31:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41285/
-----------------------------------------------------------

(Updated Jan. 20, 2016, 1:31 a.m.)


Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.


Changes
-------

Updated summary and description.


Summary (updated)
-----------------

Made Executor struct assign `pid` to be None() explicitly.


Bugs: MESOS-3550
    https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description (updated)
-------

The executor assigned `pid` to `UPID()` instead of `None()`. The value `UPID()` is used as
a special flag during recovery when the executor type is unknown i.e. no pid/http marker file
is found.


Diffs
-----

  src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a 

Diff: https://reviews.apache.org/r/41285/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message