mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 42368: Added reservation endpoint test without auth and principal.
Date Wed, 20 Jan 2016 01:30:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42368/
-----------------------------------------------------------

(Updated Jan. 20, 2016, 1:30 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
-------

Addressed comments.


Bugs: MESOS-4195
    https://issues.apache.org/jira/browse/MESOS-4195


Repository: mesos


Description
-------

Added reservation endpoint test without auth and principal.

Currently, dynamic reservation endpoints will not work when HTTP authentication is not set.
This test checks that these endpoints will fail as expected in this case.


Diffs (updated)
-----

  src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 

Diff: https://reviews.apache.org/r/42368/diff/


Testing
-------

A new test, `ReservationEndpointsTest.ReserveAndUnreserveNoAuthentication`, was added, and
make check was used to test. The new test was also run with `--gtest_repeat=1000 --gtest_break_on_failure=1`.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message