mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mp...@apache.org>
Subject Re: Review Request 42368: Added reservation endpoint test without auth and principal.
Date Wed, 20 Jan 2016 00:44:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42368/#review115293
-----------------------------------------------------------



src/tests/reservation_endpoints_tests.cpp (lines 1156 - 1157)
<https://reviews.apache.org/r/42368/#comment176266>

    Could you update `createReservationInfo` to take `Option<std::string>` and use `createReservationInfo()`
to get an empty `ReservationInfo`?



src/tests/reservation_endpoints_tests.cpp (lines 1160 - 1162)
<https://reviews.apache.org/r/42368/#comment176260>

    Can we not continue to overwrite this? It's difficult to keep track of the changing states.



src/tests/reservation_endpoints_tests.cpp (lines 1173 - 1184)
<https://reviews.apache.org/r/42368/#comment176255>

    Why are we testing for this?



src/tests/reservation_endpoints_tests.cpp (lines 1186 - 1198)
<https://reviews.apache.org/r/42368/#comment176256>

    Could you explain why this is expected to fail?



src/tests/reservation_endpoints_tests.cpp (lines 1200 - 1201)
<https://reviews.apache.org/r/42368/#comment176259>

    It seems like this framework is being spun up just to reserve resources on this agent.
Do we not have a way to reserve the resources via the HTTP endpoint?


- Michael Park


On Jan. 20, 2016, 12:11 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42368/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 12:11 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-4195
>     https://issues.apache.org/jira/browse/MESOS-4195
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added reservation endpoint test without auth and principal.
> 
> Currently, dynamic reservation endpoints will not work when HTTP authentication is not
set. This test checks that these endpoints will fail as expected in this case.
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7

> 
> Diff: https://reviews.apache.org/r/42368/diff/
> 
> 
> Testing
> -------
> 
> A new test, `ReservationEndpointsTest.ReserveAndUnreserveNoAuthentication`, was added,
and make check was used to test. The new test was also run with `--gtest_repeat=1000 --gtest_break_on_failure=1`.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message