mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Klues" <klue...@gmail.com>
Subject Review Request 42524: Simplified SchedulerDriver.run().
Date Tue, 19 Jan 2016 22:58:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42524/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Greg Mann.


Bugs: MESOS-4409
    https://issues.apache.org/jira/browse/MESOS-4409


Repository: mesos


Description
-------

Previously, the status check in run() was unnecessary due to the short
circuit path in join(). This commit simplifies run() by removing the
check completely.


Diffs
-----

  src/sched/sched.cpp 38940b7e2563a2156be2f8c228afdc27c45b6e83 

Diff: https://reviews.apache.org/r/42524/diff/


Testing
-------

Ran the entire 'make check' suite with no failures on both Mac OS X and ubuntu 14.04.


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message