mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 42470: Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.
Date Tue, 19 Jan 2016 22:13:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42470/#review115257
-----------------------------------------------------------



include/mesos/mesos.proto (line 646)
<https://reviews.apache.org/r/42470/#comment176171>

    Can we punt on that field for now for MVP?
    
    I guess the goal of this field is to let the framework tell if it has exclusive access
to the disk or not. I am wondering if we should use other primitives for this (e.g, ExclusiveInfo
at the top level of Resource), instead of this heuristic.
    
    My concern is that operator can potentially change the size of a directory (e.g., using
lvm with some filesystem), which will make this field not so reliable.



include/mesos/v1/mesos.proto (line 645)
<https://reviews.apache.org/r/42470/#comment176172>

    Ditto.


- Jie Yu


On Jan. 18, 2016, 9:23 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42470/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 9:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-4378
>     https://issues.apache.org/jira/browse/MESOS-4378
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
>   include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd 
> 
> Diff: https://reviews.apache.org/r/42470/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message