mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 42211: Added filters to disable NetClsIsolator tests.
Date Mon, 18 Jan 2016 23:06:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42211/#review115068
-----------------------------------------------------------

Ship it!



src/tests/environment.cpp (line 388)
<https://reviews.apache.org/r/42211/#comment175920>

    Could you please add a comment about why we need a seprate filter for net_cls, instead
of relying on the existing cgroups filter? (e.g., net_cls is not always available on systems
with cgroups enabled)



src/tests/environment.cpp (line 394)
<https://reviews.apache.org/r/42211/#comment175921>

    space before 'netCls'



src/tests/environment.cpp (line 395)
<https://reviews.apache.org/r/42211/#comment175930>

    Can you move this above #ifdef linux?



src/tests/environment.cpp (lines 400 - 401)
<https://reviews.apache.org/r/42211/#comment175927>

    Can you adjust the message here. In other words, please do not let the message be longer
than the '-' bar.



src/tests/environment.cpp (lines 409 - 411)
<https://reviews.apache.org/r/42211/#comment175932>

    Ditto on message formatting.



src/tests/environment.cpp (line 417)
<https://reviews.apache.org/r/42211/#comment175931>

    No need for this as I suggested above.



src/tests/environment.cpp (line 429)
<https://reviews.apache.org/r/42211/#comment175929>

    indent please


- Jie Yu


On Jan. 15, 2016, 5:42 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42211/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 5:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4262
>     https://issues.apache.org/jira/browse/MESOS-4262
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls
subsystem is disable.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 
> 
> Diff: https://reviews.apache.org/r/42211/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> * Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator
tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message