mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian Qiu" <qiuj...@cn.ibm.com>
Subject Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.
Date Mon, 18 Jan 2016 16:04:23 GMT


> On 一月 15, 2016, 8:53 p.m., Timothy Chen wrote:
> > src/tests/hook_tests.cpp, line 389
> > <https://reviews.apache.org/r/42241/diff/1/?file=1195246#file1195246line389>
> >
> >     If hookFuture never becomes ready that this blocks forever right?
> >     AWAIT_READY has a timeout built in, and we will want to also make sure we don't
hang forever.
> >     Also do we have a logically expected time the hook future should be ready? Can
we just advance once and then AWAIT?
> 
> Jian Qiu wrote:
>     Thanks, @tnachen. the while loop here is to wait for the executor being terminated.
Instead of checking hookFuture in while loop, how about exepect a call to executorTerminated,
and check whether it is called in while loop?

After rechecking the test case, you are right that we should not use a loop here.


- Jian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review114762
-----------------------------------------------------------


On 一月 18, 2016, 4:03 p.m., Jian Qiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> -----------------------------------------------------------
> 
> (Updated 一月 18, 2016, 4:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
>     https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -----
> 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> -------
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message