mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.
Date Mon, 18 Jan 2016 14:01:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/#review115003
-----------------------------------------------------------


Patch looks great!

Reviews applied: [42247]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh

- Mesos ReviewBot


On Jan. 18, 2016, 11:14 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42247/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 11:14 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-4329
>     https://issues.apache.org/jira/browse/MESOS-4329
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Waiting for the launch result is not enough as it is unrelated to
> whether the launched container has terminated. If we do not wait for
> that the global teardown might find it still running and fail the tests
> (this can happen if we e.g., execute this test in isolation).
> 
> Also along the name of the launch result to following the canonical
> scheme.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 7fe566770bbd802111885de061a53a3edf914840 
> 
> Diff: https://reviews.apache.org/r/42247/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message