> On Jan. 18, 2016, 2:12 a.m., Guangya Liu wrote:
> > include/mesos/docker/spec.proto, line 33
> > <https://reviews.apache.org/r/42235/diff/2/?file=1199517#file1199517line33>
> >
> > Can you please also add some comments here? The tag can be either "latest" or
the image version.
Added.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/#review114929
-----------------------------------------------------------
On Jan. 18, 2016, 6:53 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42235/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 6:53 a.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The goal here is to replace Image::Name with ImageReference and the
> corresponding parsing method, which will be done in a subsequent patch.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.proto PRE-CREATION
> src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10
> src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1
> src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd
> src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2
> src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803
> src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5
> src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41
> src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa
> src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664
>
> Diff: https://reviews.apache.org/r/42235/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
|