mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongqiao Wang" <yq...@cn.ibm.com>
Subject Re: Review Request 41789: Expose the http::internal::request function.
Date Mon, 18 Jan 2016 06:48:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/
-----------------------------------------------------------

(Updated Jan. 18, 2016, 6:48 a.m.)


Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil Conway, and Qian
Zhang.


Changes
-------

Add test.


Bugs: MESOS-3763
    https://issues.apache.org/jira/browse/MESOS-3763


Repository: mesos


Description
-------

Expose the internal::http::request function in the header and not add an additional method/overload
for put function.

(TODO): Clean the other instances of post/get to use the http::request method.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/http.hpp 1fe549e9c3c64b310048388d90ab04e5641e08a1 
  3rdparty/libprocess/src/http.cpp 40fd87c4aa1417d4746a5e4268c30c0e55d0ec0e 
  3rdparty/libprocess/src/tests/http_tests.cpp c23d0bf1929686cfc42969f39ce046f4794539d4 

Diff: https://reviews.apache.org/r/41789/diff/


Testing
-------

Make & Make check successfully.


Thanks,

Yongqiao Wang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message