mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.
Date Sun, 17 Jan 2016 19:42:23 GMT


> On Jan. 13, 2016, 6:44 p.m., Gilbert Song wrote:
> > src/docker/spec.cpp, line 62
> > <https://reviews.apache.org/r/42235/diff/1/?file=1195232#file1195232line62>
> >
> >     We remove setting default tag as `latest`, is it because not necessary to set
(if no tag is specified, it will pull the latest-tagged image)?

Yeah, I think this logic belongs to the caller. The utility function here will just do the
parsing.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/#review114250
-----------------------------------------------------------


On Jan. 13, 2016, 6:21 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42235/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 6:21 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The goal here is to replace Image::Name with ImageReference and the
> corresponding parsing method, which will be done in a subsequent patch.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.proto PRE-CREATION 
>   src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
>   src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
>   src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
>   src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
>   src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803

>   src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5

>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41

>   src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa

>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664

> 
> Diff: https://reviews.apache.org/r/42235/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message