mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.
Date Sun, 17 Jan 2016 05:29:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review114896
-----------------------------------------------------------


Thanks! Just a small comment below.


support/docker_build.sh (lines 125 - 135)
<https://reviews.apache.org/r/42100/#comment175735>

    Are you sure that this doesn't over-write the period trap?
    
    http://stackoverflow.com/questions/3338030/multiple-bash-traps-for-the-same-signal


- Ben Mahler


On Jan. 9, 2016, 2:38 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
>     https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message