mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shuai Lin" <linshuai2...@gmail.com>
Subject Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI
Date Sun, 17 Jan 2016 03:50:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32975/#review114895
-----------------------------------------------------------



src/tests/fetcher_tests.cpp (line 706)
<https://reviews.apache.org/r/32975/#comment175734>

    What about adding another test case, e.g. `ROOT_ExtractChownUser`, which would be executed
when the tests are running as the root user, and automatically disabled if not. 
    
    In this test case we can set chown target to some famous linux system user, e.g. `daemon`.


- Shuai Lin


On Jan. 13, 2016, 6:06 p.m., Jim Klucar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32975/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 6:06 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1790
>     https://issues.apache.org/jira/browse/MESOS-1790
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added chown to CommandInfo.URI protocol buffer as an optional
> boolean that defaults to true, the current chown behavior.
> 
> The fetcher was updated to skip the os::chown operation if the chown
> boolean is set to false.
> 
> No documentation was updated.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 
>   src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b 
>   src/launcher/fetcher.cpp 796526f59c25898ef6db2b828b0e2bb7b172ba25 
>   src/tests/fetcher_tests.cpp 4549e6a631e2c17cec3766efaa556593eeac9a1e 
> 
> Diff: https://reviews.apache.org/r/32975/diff/
> 
> 
> Testing
> -------
> 
> Unit testing this functionality is difficult because it would require that the user running
the test to have permission to chown a file to someone other than themselves. I didn't want
to add that as a requirement to build. I added the new field to the existing test cases just
to see that they populate.
> 
> 
> Thanks,
> 
> Jim Klucar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message