mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avinash sridharan" <avin...@mesosphere.io>
Subject Re: Review Request 42048: Implemented the CgroupNetClsIsolatorProcess.
Date Fri, 15 Jan 2016 22:53:29 GMT


> On Jan. 15, 2016, 7:55 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, line 210
> > <https://reviews.apache.org/r/42048/diff/2/?file=1189510#file1189510line210>
> >
> >     No need to add 'Failed to prepare isolator', the caller should have already
printed it.
> >     
> >     ```
> >     return Failure("Failed to check if the cgroup already exists");
> >     ```

Will convert it to this :
return Failure("Failed to check if the cgroup already exists" + exists.error()); 

Wanted to capture any error thrown by the cgroup::exists call ?


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42048/#review114617
-----------------------------------------------------------


On Jan. 15, 2016, 10:53 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42048/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 10:53 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4262
>     https://issues.apache.org/jira/browse/MESOS-4262
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Defined the CgroupNetClsIsolatorProcess.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42048/diff/
> 
> 
> Testing
> -------
> 
> make check . Added a test case for CgroupNetClsIsolatorProcess.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message