mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 41936: Required role in set quota request explicitly.
Date Fri, 15 Jan 2016 21:35:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41936/#review114773
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On Jan. 12, 2016, 9:32 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41936/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 9:32 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4058
>     https://issues.apache.org/jira/browse/MESOS-4058
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A set quota request must provide a role, which now must be passed as
> a top-level field in the request JSON and not in `Resource` objects.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 134a93b1d1b6e050aa8a5037ffbec2cc305b0694 
>   src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a 
>   src/tests/role_tests.cpp 373ae267b85588fe491ab0a0ce8aa195f971aac3 
> 
> Diff: https://reviews.apache.org/r/41936/diff/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.10.5
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message