mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41962: Add test for ContainerLogger recovery after agent failover.
Date Fri, 15 Jan 2016 21:03:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41962/
-----------------------------------------------------------

(Updated Jan. 15, 2016, 1:03 p.m.)


Review request for mesos, Benjamin Hindman, Gilbert Song, Artem Harutyunyan, Jie Yu, and Timothy
Chen.


Changes
-------

Move the mock expectation for `MockContainerLogger*` to before the containerizer is created,
i.e. before `MockContainerLogger*` is `Owned<...>` by the containerizer.

Update test due to addition of `Provisioner` to the MesosContainerizer.


Summary (updated)
-----------------

Add test for ContainerLogger recovery after agent failover.


Bugs: MESOS-4150
    https://issues.apache.org/jira/browse/MESOS-4150


Repository: mesos


Description (updated)
-------

Add test for ContainerLogger recovery after agent failover.


Diffs (updated)
-----

  src/tests/container_logger_tests.cpp c6b2e597517c74a55649287dc5ae5a3115f9a640 
  src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 

Diff: https://reviews.apache.org/r/41962/diff/


Testing
-------

make (OSX & Centos7)

Tests are run in the next review.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message