mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilbert Song" <songzihao1...@gmail.com>
Subject Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.
Date Fri, 15 Jan 2016 20:23:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114758
-----------------------------------------------------------



src/uri/fetchers/docker.cpp (lines 31 - 32)
<https://reviews.apache.org/r/42238/#comment175617>

    Add `#include <stout/strings.hpp>`.



src/uri/fetchers/docker.cpp (line 575)
<https://reviews.apache.org/r/42238/#comment175614>

    Should we take `strings::tokenize(tokens[1], ",")` out and check its size?



src/uri/fetchers/docker.cpp (lines 576 - 581)
<https://reviews.apache.org/r/42238/#comment175615>

    Do we allow any of `"xxx", "yyy", "zzz"` to be empty? If not, it may be more safe to use
`strings::tokenize`.



src/uri/fetchers/docker.cpp (lines 598 - 601)
<https://reviews.apache.org/r/42238/#comment175616>

    Should we handle removing quotation marks here?


- Gilbert Song


On Jan. 13, 2016, 3:14 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 3:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the Docker URI fetcher plugin based on curl.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf 
> 
> Diff: https://reviews.apache.org/r/42238/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message