mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Review Request 42358: Logger Module: Refactored Sandbox logger initialization.
Date Fri, 15 Jan 2016 19:34:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42358/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Bugs: MESOS-4136
    https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description
-------

In retrospect, the `if (process != NULL)` initialization check in each sandbox logger function
is unnecessary for such a simple module.


Diffs
-----

  src/slave/container_loggers/sandbox.hpp 17bb1d9791d46c834e7d074fc72c95f093cad990 
  src/slave/container_loggers/sandbox.cpp 1b954d64ba97f650b1024eed383ca46093ca1b6b 

Diff: https://reviews.apache.org/r/42358/diff/


Testing
-------

make check


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message