mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cong Wang" <xiyou.wangc...@gmail.com>
Subject Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class.
Date Fri, 15 Jan 2016 19:21:10 GMT


> On Jan. 15, 2016, 6 a.m., Cong Wang wrote:
> > Why do we need netcls to regulate framework traffic on a per-container basis? Given
the fact that a) the port range based filters already work and the code (see egress fq_codel)
already exists b) we only have port range based network isolation so far.
> > 
> > I see no point of this. Please describe your use case with details, just pointing
to netcls kernel doc doesn't help at all.
> 
> Cong Wang wrote:
>     Since no one answers this, I assume no one in Mesosphere actually understands it...
So looks like you are pushing something no one is actually going to use.
> 
> Avinash sridharan wrote:
>     The egress_fq_codel that you are pointing too (I am assuming this is the jira you
are refferring to https://issues.apache.org/jira/browse/MESOS-2422) needs port mapping isolator
to enforce QoS on any egress traffic shaping/policing, and for that matter any network policy
enforcement.  
>     
>     The net_cls cgroup is a linux kernel construct that allows operators to support traffic
shapping/policing and any network policy enforcement using existing networking tools like
tc and iptables. By enabling net_cls cgroup it gives mesos a more generalized way of allowing
operators to enforce network policy irrespective of whether the task is running in the global
namespace or in a specific network namespace. In other words it will allow network policy
enforcement to take place irrespective of the type of network isolator you are using. For
e.g., if someone wants to use ip-per-container (MESOS-2044) vs the port mapping isolator,
operators would still be able to perform policy enforcement without relying on the network
isolator to provide those constructs.

True, I know what netcls is more than you do, but you just ignore the fact that we _only_
have port mapping isolator in our _current_ code, that is my whole point. We can always add
this _after_ ip-per-container work is merged in upstream, it is never too late.

No need to mention this is hard to work together with the fq_codel filters on egress. This
is why I ask for more details, but you still don't give any detail so far.


- Cong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42047/#review114665
-----------------------------------------------------------


On Jan. 15, 2016, 5:42 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42047/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 5:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4262
>     https://issues.apache.org/jira/browse/MESOS-4262
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a
mesos container using the net_cls cgroup subsystem.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
>   src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42047/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message