mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 41789: Expose the http::internal::request function.
Date Fri, 15 Jan 2016 07:56:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/#review114682
-----------------------------------------------------------



3rdparty/libprocess/src/http.cpp (line 1280)
<https://reviews.apache.org/r/41789/#comment175545>

    Would it make sense to add a test (e.g. testing DELETE)?


- Joerg Schad


On Jan. 15, 2016, 7:50 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41789/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil Conway, and
Qian Zhang.
> 
> 
> Bugs: MESOS-3763
>     https://issues.apache.org/jira/browse/MESOS-3763
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose the internal::http::request function in the header and not add an additional method/overload
for put function.
> 
> (TODO): Clean the other instances of post/get to use the http::request method.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp d0f820e0850955c01c5149fef2f05a1becb4bd32

>   3rdparty/libprocess/src/http.cpp aabfd5dd1f93c190edce6d54e977dc56034c1ac9 
> 
> Diff: https://reviews.apache.org/r/41789/diff/
> 
> 
> Testing
> -------
> 
> Make & Make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message