mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 42264: Fixed a GMock warning in RoleTest.ImplicitRoleStaticReservation.
Date Fri, 15 Jan 2016 03:11:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42264/#review114646
-----------------------------------------------------------


Patch looks great!

Reviews applied: [42264]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh

- Mesos ReviewBot


On Jan. 13, 2016, 9:23 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42264/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 9:23 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
> 
> 
> Bugs: MESOS-4357
>     https://issues.apache.org/jira/browse/MESOS-4357
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a GMock warning in RoleTest.ImplicitRoleStaticReservation.
> 
> 
> Diffs
> -----
> 
>   src/tests/role_tests.cpp 373ae267b85588fe491ab0a0ce8aa195f971aac3 
> 
> Diff: https://reviews.apache.org/r/42264/diff/
> 
> 
> Testing
> -------
> 
> Ran the test a few hundred times with and without the change; without the change, a warning
is observed. With the change, no warning is observed.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message