mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 42182: Fixed check thereby allowing HTTP executors to reconnect.
Date Fri, 15 Jan 2016 01:13:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42182/#review114625
-----------------------------------------------------------



src/slave/http.cpp (lines 267 - 272)
<https://reviews.apache.org/r/42182/#comment175479>

    you can just pull this down to #290 and remove the  call type check in the if statement.


- Vinod Kone


On Jan. 12, 2016, 5:46 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42182/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 5:46 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4255
>     https://issues.apache.org/jira/browse/MESOS-4255
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, we used to return a `ServiceUnavailable` when slave was recovering. However,
we only need to do so, for all other calls and let `Subscribe` pass through.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 66abdcb12d670bc4b77fa5b5f8ce35220f9aa698 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
> 
> Diff: https://reviews.apache.org/r/42182/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message