mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.
Date Thu, 14 Jan 2016 22:55:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/#review114596
-----------------------------------------------------------



src/master/allocator/mesos/hierarchical.cpp (line 366)
<https://reviews.apache.org/r/39628/#comment175437>

    s/can get resource/can be offered resources/
    
    s/active/getting activated/



src/tests/hierarchical_allocator_tests.cpp (line 1842)
<https://reviews.apache.org/r/39628/#comment175438>

    2 blank lines between outer elements.



src/tests/hierarchical_allocator_tests.cpp (lines 1843 - 1844)
<https://reviews.apache.org/r/39628/#comment175439>

    How about
    
    // This test checks that if a framework suppresses offers, disconnects and reconnects
again,
    // it will starting receiving resource offers again.



src/tests/hierarchical_allocator_tests.cpp (line 1891)
<https://reviews.apache.org/r/39628/#comment175446>

    // Total cluster resources will become cpus=4, mem=2048.



src/tests/hierarchical_allocator_tests.cpp (line 1914)
<https://reviews.apache.org/r/39628/#comment175450>

    I'm not sure why you needed to have framework2 and slave2 in this test at all?
    
    can't you just do
    
    // framework1 suppresses offers
    
    // ensure no offers are received. i.e., 'allocaiton' is pending.
    
    // framework1 is deactivated and reactivated.
    
    // ensure offer for slave1 is received.


- Vinod Kone


On Jan. 14, 2016, 9:53 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39628/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 9:53 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3802
>     https://issues.apache.org/jira/browse/MESOS-3802
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleared the suppressed flag when deactive a framework.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056

>   src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59

> 
> Diff: https://reviews.apache.org/r/39628/diff/
> 
> 
> Testing
> -------
> 
> Ubuntu 14.04
> make 
> make check
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework"
--verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message