mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Review Request 42324: Fixed a misleading log message when accepting inverse offers.
Date Thu, 14 Jan 2016 22:41:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42324/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van Remoortere.


Bugs: MESOS-4301
    https://issues.apache.org/jira/browse/MESOS-4301


Repository: mesos


Description
-------

Accepting an inverse offer will result in the master printing out "ACCEPT call used invalid
offers ...", even if all inverse offers are actually valid.  We silence the logs in this case.


Diffs
-----

  src/master/master.cpp 863a11c82d322f56db1ccf25b73a4ffff1304a46 

Diff: https://reviews.apache.org/r/42324/diff/


Testing
-------

make check

# Check the following for blank output
bin/mesos-tests.sh --gtest_filter="*Inverse*Offer*" --verbose 2>&1 /dev/null |  grep
"ACCEPT call used invalid offers"


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message