mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.
Date Thu, 14 Jan 2016 21:51:44 GMT


> On Jan. 14, 2016, 12:29 a.m., Jojy Varghese wrote:
> > src/uri/fetchers/docker.cpp, line 219
> > <https://reviews.apache.org/r/42238/diff/2/?file=1196119#file1196119line219>
> >
> >     Can be refactored to common function (and avoid duplicate code at L124).

There're some subtle differences. I'll add a TODO here. Basically, the await logic should
go to Subprocess (i.e., we can introduce a method similar to Popen.communicate in python).


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114342
-----------------------------------------------------------


On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 11:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the Docker URI fetcher plugin based on curl.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf 
> 
> Diff: https://reviews.apache.org/r/42238/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message