mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.
Date Thu, 14 Jan 2016 21:47:31 GMT


> On Jan. 14, 2016, 5:54 p.m., Jojy Varghese wrote:
> > One of the concerns for spawning shells for image fetching is that there will be
a lot of forks per image. For example - docker image fetch will have 1 initial request, 1
token request, 1 manifest request, N layer requests, N validation (SHA calculation). 
> > 
> > I was wondering if we can have one bash script that does all of this and we launch
that.

Are you concerned about performance? Let's optimize it once we have data to show that it's
a problem.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114511
-----------------------------------------------------------


On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 11:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the Docker URI fetcher plugin based on curl.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf 
> 
> Diff: https://reviews.apache.org/r/42238/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message