mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39805: Moved filesystems tests to their own file.
Date Thu, 14 Jan 2016 21:15:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39805/#review114570
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (lines 26 - 27)
<https://reviews.apache.org/r/39805/#comment175413>

    order



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 42)
<https://reviews.apache.org/r/39805/#comment175414>

    let's remove the unnecessary whitespace now that we're touching this line `> >`
-> `>>`.
    This is something we've been changing as we touch lines since modern compilers don't require
this whitespace anymore.



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 71)
<https://reviews.apache.org/r/39805/#comment175415>

    `> >` -> `>>`
    Check all the touched lines for this please :-)


- Joris Van Remoortere


On Jan. 12, 2016, 8:41 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39805/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 8:41 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved filesystems tests to their own file.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5ab7bc4966fe32eaddd573a4dbfd997f98b5d481

>   3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 3cff837886d94d623c732371380f1c62750022f4

>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 62ad461eb228b688f1ceac16cfb003561ed5a806

>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39805/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message