mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Klues" <klue...@gmail.com>
Subject Re: Review Request 42309: Fallback to --git-dir when --git-common-dir not available.
Date Thu, 14 Jan 2016 19:56:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42309/
-----------------------------------------------------------

(Updated Jan. 14, 2016, 7:56 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
-------

Address Benjamin Bannier's comments.


Bugs: MESOS-4374
    https://issues.apache.org/jira/browse/MESOS-4374


Repository: mesos


Description
-------

The newly introduced way of finding the .git directory via
--git-common-dir is only supported on newer versions of git. Fallback to
the older --git-dir method if --git-common-dir is not supported.


Diffs (updated)
-----

  bootstrap 519090d696ae09dac70318e91ade583b38f44048 
  support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44 

Diff: https://reviews.apache.org/r/42309/diff/


Testing
-------

Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git 2.6.3 and git 2.2.0
repsectively.


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message