mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilbert Song" <songzihao1...@gmail.com>
Subject Re: Review Request 41815: Unified Container: Added provisioner to mesos containerizer.
Date Thu, 14 Jan 2016 17:34:21 GMT


> On Jan. 14, 2016, 1:55 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 182
> > <https://reviews.apache.org/r/41815/diff/2/?file=1185602#file1185602line182>
> >
> >     I think we may need to update this comment since provisioner will be pulled
from linux filesystem isolator to Mesos containerizer.

Thank you for reviewing, Qian! I removed this comment.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41815/#review114448
-----------------------------------------------------------


On Jan. 14, 2016, 9:34 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41815/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 9:34 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4240
>     https://issues.apache.org/jira/browse/MESOS-4240
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified Container: Added provisioner to mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 89d18624b08f2c953b9fa21663aeda694d4aac12

>   src/slave/containerizer/mesos/containerizer.cpp f3c370aeb331beb6202fd30cd0278877da0b42e0

>   src/tests/containerizer/filesystem_isolator_tests.cpp 5bb85034c22caef64054c1629f6fd55d227e48b1

>   src/tests/containerizer/mesos_containerizer_tests.cpp 95b493c6f479eef52ee0c9a44ac40254ed76ebae

> 
> Diff: https://reviews.apache.org/r/41815/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message