mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 41780: Changed ContainerLogger and Fetcher to not duplicate FDs.
Date Thu, 14 Jan 2016 15:42:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41780/#review114485
-----------------------------------------------------------

Ship it!


My comment on https://reviews.apache.org/r/41779/
may change "false" to "NO_DUPLICATE" here.

- Bernd Mathiske


On Jan. 13, 2016, 6:12 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41780/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4136
>     https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change shifts the burden of FD lifecycle management away from ContainerLogger module
writers.
> This change also cleans up the Fetcher code slightly.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp a2362070ead0afcef1e6c2ca784083ddb01ba51a 
>   src/slave/containerizer/fetcher.cpp 4ac9149980cf7f013b318218a1b29369c5dcff17 
> 
> Diff: https://reviews.apache.org/r/41780/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message