mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 42288: Docker container REST API /monitor/statistics.json output have no timestamp field
Date Thu, 14 Jan 2016 07:16:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/#review114430
-----------------------------------------------------------



src/slave/containerizer/docker.cpp (line 1367)
<https://reviews.apache.org/r/42288/#comment175273>

    What about update the comments same as mesos docker containizer? The current comments
seems does not fit in here well.
    
    // Set the timestamp now we have all statistics.


- Guangya Liu


On 一月 14, 2016, 7:09 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42288/
> -----------------------------------------------------------
> 
> (Updated 一月 14, 2016, 7:09 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4328
>     https://issues.apache.org/jira/browse/MESOS-4328
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Docker container REST API /monitor/statistics.json output have no timestamp field
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp da19975 
> 
> Diff: https://reviews.apache.org/r/42288/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message