mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <klaus1982...@gmail.com>
Subject Re: Review Request 42113: Handle unreserve logic for dynamic reservation (2/3).
Date Thu, 14 Jan 2016 06:17:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42113/#review114419
-----------------------------------------------------------



src/master/allocator/mesos/hierarchical.cpp (line 692)
<https://reviews.apache.org/r/42113/#comment175254>

    `freeAllocationSlack` is unused in the following codes? Why it's here.



src/master/allocator/mesos/hierarchical.cpp (lines 707 - 710)
<https://reviews.apache.org/r/42113/#comment175259>

    Should be
    
        if (freeAllocationSlack.empty())
          break;
    
        Resources freeResources = freeAllocationSlack.get(name);
        
        if (freeResources.contains(unreservedResources)) {
          slaves[slaveId].total -= unreservedResources;
          freeAllocationSlack -= unreservedResources;
        } else {
          slaves[slaveId].total -= freeResources;
          freeAllocationSlack -= freeResources;
        }



src/master/allocator/mesos/hierarchical.cpp (line 708)
<https://reviews.apache.org/r/42113/#comment175255>

    There should be `freeAllocationSlack` which is not allocated for now.


- Klaus Ma


On Jan. 13, 2016, 9:01 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42113/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph
Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4145
>     https://issues.apache.org/jira/browse/MESOS-4145
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Handle unreserve logic for dynamic reservation with allocation slack.
> 
> This patch is halding the case when using updateAllocation to unreserve
> some resources.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056

>   src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59

> 
> Diff: https://reviews.apache.org/r/42113/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message