mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 41946: Added a `Representation` abstraction to stout.
Date Thu, 14 Jan 2016 04:18:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41946/#review114401
-----------------------------------------------------------

Ship it!


LGTM, but see issues on documentation and comments please.

This is a really nice addition MPark, thank you! Are you also going to follow up and replace
our current `RFC*` implemenetations too?


3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp (line 36)
<https://reviews.apache.org/r/41946/#comment175240>

    Can you document why you need this please? What happens if you don't add this?



3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp (line 58)
<https://reviews.apache.org/r/41946/#comment175242>

    { on newline please.



3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp (line 68)
<https://reviews.apache.org/r/41946/#comment175241>

    Why do you need this? Can you add a comment please?


- Benjamin Hindman


On Jan. 6, 2016, 10 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41946/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 10 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe

>   3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41946/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message