mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Klues" <klue...@gmail.com>
Subject Re: Review Request 42212: Added unit test for framework/task history flags.
Date Thu, 14 Jan 2016 02:52:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114385
-----------------------------------------------------------



src/tests/master_tests.cpp (line 3989)
<https://reviews.apache.org/r/42212/#comment175225>

    As bmahler pointed out offline, mesos doesn't typically use loop variables such as 'fid'
and 'tid'. It prefers simple variable names such as {i, j} or more explicit variable names
such as {frameworkIndex, taskIndex}.  I will update this throughout.



src/tests/master_tests.cpp (line 4104)
<https://reviews.apache.org/r/42212/#comment175223>

    As bmahler pointed out offline, this comment is unnecessary. It doesn't add to the story
being told by this code and implies that such a comment would be needed in all tests that
called Shutdown().
    
    What I meant to clarify was that we were shutting down the current master for this iteration
of the loop -- which isn't necessarily clear and does deserve a comment. I plan to update
the comment accordingly.



src/tests/master_tests.cpp (line 4106)
<https://reviews.apache.org/r/42212/#comment175224>

    As bmahler pointed out offline, we should really be using Stop(master.get()) here instead
of shutdown.
    
    I originally called Shutdown() due to a comment in MesosTest::Shutdown() about properly
unsetting the authenticators on the master upon shutdown. However, bmahler said this shouldn't
be an issue for the current test and that Stop() is more appropriate in this loop with a single
master per iteration.


- Kevin Klues


On Jan. 13, 2016, 11:01 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 11:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
>     https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> -------
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message