mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <>
Subject Re: Review Request 42052: Refactored Subprocess::IO to improve readability.
Date Thu, 14 Jan 2016 01:55:26 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 13, 2016, 5:55 p.m.)

Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Got rid of the abstract type, in favor of Lambdas!!

Summary (updated)

Refactored Subprocess::IO to improve readability.

Bugs: MESOS-4136

Repository: mesos

Description (updated)

Replaced `int pipefd[2]` with the structs `InputFileDescriptors` and `OutputFileDescriptors`.
Replaced the `switch` statements inside `process::subprocess` with lambdas defined in the
static helpers (`PIPE`, `PATH`, `FD`).

Slight cleanup of Subprocess code.

Diffs (updated)

  3rdparty/libprocess/include/process/subprocess.hpp 8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec

  3rdparty/libprocess/src/subprocess.cpp 863523404b9ef1d2024c108f3e9e1c77c3916049 


Testing (updated)

make check


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message