mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Klues" <klue...@gmail.com>
Subject Re: Review Request 42266: Updated post-reviews.py to strip review URL in RR summary.
Date Wed, 13 Jan 2016 23:23:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42266/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 11:23 p.m.)


Review request for mesos, Artem Harutyunyan and Till Toenshoff.


Changes
-------

Simplify so that this patch is less invasive to the previous revision than before. In general,
this file could use a massive overhaul to extract key functionality into helper functions
and call them from some primary flow of logic. It also shares functionality with apply-reviews,
which could be abstracted out as well eventually.  For now, let's do the minimal possible
to get the review URL stripped out of the commit message before posting back to reviewboard.


Repository: mesos


Description
-------

Previously, when setting GUESS_FIELDS in .reviewboardrc to automatically
update the summary message when posting a review, the summary would
include the review URL in the summary message. This was due to the fact
that GUESS_FILEDS simply copies the entirety of the commit message into
the RR summary field on reviewboard. Including this line is both
redundant, and, in some cases, has been found to appear (at least) twice
in the summary message instead of just once.

This commit ensures that the commit message posted when GUESS_FIELDS is
set will have the review URL stripped before posting.


Diffs (updated)
-----

  support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e 

Diff: https://reviews.apache.org/r/42266/diff/


Testing
-------


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message