mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 42216: Fixed gmock warnings in hook tests.
Date Wed, 13 Jan 2016 22:20:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42216/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 10:20 p.m.)


Review request for mesos, Joris Van Remoortere, Neil Conway, and Timothy Chen.


Changes
-------

Modified description to include test names


Bugs: MESOS-4348
    https://issues.apache.org/jira/browse/MESOS-4348


Repository: mesos


Description (updated)
-------

We did not have an expectation on the `shutdown` method of the `MockExecutor`. This led to
the gmock warning being emitted in some runs. The tests that are being fixed are:

- `HookTest.VerifyMasterLaunchTaskHook`
- `HookTest.VerifySlaveRunTaskHook`
- `HookTest.VerifySlaveTaskStatusDecorator`


Diffs
-----

  src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f 

Diff: https://reviews.apache.org/r/42216/diff/


Testing
-------

Loop the tests for 1000 times.


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message