mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 42052: Refactored Subprocess::IO into an abstract type.
Date Wed, 13 Jan 2016 22:02:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42052/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 2:02 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
-------

Applied BenH's changes (discussed offline) and polished it up.


Summary (updated)
-----------------

Refactored Subprocess::IO into an abstract type.


Bugs: MESOS-4136
    https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description (updated)
-------

Subprocess::PATH/FD/PIPE are changed from static helpers to subclasses.
Replaced `int pipefd[2]` with the structs `InputFileDescriptors` and `OutputFileDescriptors`.

Slight cleanup of Subprocess code.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/subprocess.hpp 8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec

  3rdparty/libprocess/src/subprocess.cpp 863523404b9ef1d2024c108f3e9e1c77c3916049 

Diff: https://reviews.apache.org/r/42052/diff/


Testing
-------

make check (next review)


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message